Add libtatsu formula #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: unilock <[email protected]>
|
|
stek29
reviewed
Sep 24, 2024
Comment on lines
+14
to
+18
| # bottle do | ||
| # root_url "https://github.com/stek29/homebrew-idevice/releases/download/libirecovery-1.1.0-25-g447ae09" | ||
| # sha256 cellar: :any, arm64_sonoma: "3a3b9c1c585ab8fd269768d317559d486c0f0fb34fc94e885f4ee4a55f51f038" | ||
| # sha256 cellar: :any, ventura: "839aa7ff745790403e66f3ac5d114480d07d9ae25b4c6bead9bfc8571de9e82c" | ||
| # end |
stek29
reviewed
Sep 24, 2024
Comment on lines
+4
to
+6
| url "https://github.com/libimobiledevice/libtatsu.git", | ||
| revision: "e3eb2e224781f6522e2cf63c35c2c249747d648d" | ||
| version "1.0.3" |
There was a problem hiding this comment.
since tagged release version is used, please replace it with a url to a specific version – see fsmon for example
something like this:
url "https://github.com/libimobiledevice/libtatsu/archive/refs/tags/1.0.3.tar.gz"
sha256 "3e039497bb90439dc01ead2b78ccbdf76dfce21b3fdd8f21a1ac584934e33a44"
stek29
reviewed
Sep 24, 2024
| --disable-silent-rules | ||
| ] | ||
|
|
||
| system "./autogen.sh", *std_configure_args, *args |
There was a problem hiding this comment.
if you replace sha revision with a tagged tarball, replace autogen.sh with ./configure too
|
wow, thank you and sorry for the long wait! I've left some comments, I can fix them up myself and get this merged, if you're ok with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idevicerestoreandlibimobiledevicehave a new compile time dependency:libtatsu.This PR adds a formula for it and adjusts the dependencies of other formulae appropriately.